fix(charts): round only top/right corners of bars instead of all four corners#10982
Open
creazyfrog wants to merge 1 commit into
Open
fix(charts): round only top/right corners of bars instead of all four corners#10982creazyfrog wants to merge 1 commit into
creazyfrog wants to merge 1 commit into
Conversation
Contributor
|
@creazyfrog is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
…f horizontal bars (fixes shadcn-ui#10741)
9278f25 to
7430381
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
radius={N}which rounds all four corners including the bottom edge that sits on the axis baselineChanges
All changes are in
apps/v4/registry/new-york-v4/charts/:chart-bar-default.tsxradius={8}radius={[8, 8, 0, 0]}chart-bar-active.tsxradius={8}radius={[8, 8, 0, 0]}chart-bar-label.tsxradius={8}radius={[8, 8, 0, 0]}chart-bar-multiple.tsx(×2)radius={4}radius={[4, 4, 0, 0]}chart-bar-label-custom.tsxradius={4}radius={[4, 4, 0, 0]}chart-bar-mixed.tsxradius={5}radius={[5, 5, 0, 0]}chart-bar-horizontal.tsxradius={5}radius={[0, 5, 5, 0]}In Recharts the array form is
[topLeft, topRight, bottomRight, bottomLeft]:[N, N, 0, 0][0, N, N, 0]Testing
Visual-only change. Default appearance is improved: bars now sit flush on the axis baseline. No logic or data changes.
Closes #10741
🤖 Generated with Claude Code