Skip to content

fix(charts): round only top/right corners of bars instead of all four corners #10982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
creazyfrog wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(charts): round only top/right corners of bars instead of all four corners #10982

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/v4/registry/new-york-v4/charts/chart-bar-active.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ export function ChartBarActive() {
<Bar
dataKey="visitors"
strokeWidth={2}
radius={8}
radius={[8, 8, 0, 0]}
shape={({ index, ...props }: BarShapeProps) =>
index === ACTIVE_INDEX ? (
<Rectangle
Expand Down
2 changes: 1 addition & 1 deletion apps/v4/registry/new-york-v4/charts/chart-bar-default.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ export function ChartBarDefault() {
cursor={false}
content={<ChartTooltipContent hideLabel />}
/>
<Bar dataKey="desktop" fill="var(--color-desktop)" radius={8} />
<Bar dataKey="desktop" fill="var(--color-desktop)" radius={[8, 8, 0, 0]} />
</BarChart>
</ChartContainer>
</CardContent>
Expand Down
2 changes: 1 addition & 1 deletion apps/v4/registry/new-york-v4/charts/chart-bar-horizontal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ export function ChartBarHorizontal() {
cursor={false}
content={<ChartTooltipContent hideLabel />}
/>
<Bar dataKey="desktop" fill="var(--color-desktop)" radius={5} />
<Bar dataKey="desktop" fill="var(--color-desktop)" radius={[0, 5, 5, 0]} />
</BarChart>
</ChartContainer>
</CardContent>
Expand Down
2 changes: 1 addition & 1 deletion apps/v4/registry/new-york-v4/charts/chart-bar-label-custom.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ export function ChartBarLabelCustom() {
cursor={false}
content={<ChartTooltipContent indicator="line" />}
/>
<Bar dataKey="desktop" fill="var(--color-desktop)" radius={4}>
<Bar dataKey="desktop" fill="var(--color-desktop)" radius={[4, 4, 0, 0]}>
<LabelList
dataKey="month"
position="insideLeft"
Expand Down
2 changes: 1 addition & 1 deletion apps/v4/registry/new-york-v4/charts/chart-bar-label.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ export function ChartBarLabel() {
cursor={false}
content={<ChartTooltipContent hideLabel />}
/>
<Bar dataKey="desktop" fill="var(--color-desktop)" radius={8}>
<Bar dataKey="desktop" fill="var(--color-desktop)" radius={[8, 8, 0, 0]}>
<LabelList
position="top"
offset={12}
Expand Down
2 changes: 1 addition & 1 deletion apps/v4/registry/new-york-v4/charts/chart-bar-mixed.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ export function ChartBarMixed() {
cursor={false}
content={<ChartTooltipContent hideLabel />}
/>
<Bar dataKey="visitors" radius={5} />
<Bar dataKey="visitors" radius={[5, 5, 0, 0]} />
</BarChart>
</ChartContainer>
</CardContent>
Expand Down
4 changes: 2 additions & 2 deletions apps/v4/registry/new-york-v4/charts/chart-bar-multiple.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,8 @@ export function ChartBarMultiple() {
cursor={false}
content={<ChartTooltipContent indicator="dashed" />}
/>
<Bar dataKey="desktop" fill="var(--color-desktop)" radius={4} />
<Bar dataKey="mobile" fill="var(--color-mobile)" radius={4} />
<Bar dataKey="desktop" fill="var(--color-desktop)" radius={[4, 4, 0, 0]} />
<Bar dataKey="mobile" fill="var(--color-mobile)" radius={[4, 4, 0, 0]} />
</BarChart>
</ChartContainer>
</CardContent>
Expand Down
Loading