Fix target_soc passed as float in service API calls#4215
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix target_soc type from float to int
Fix target_soc passed as float in service API calls
Jul 8, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes Home Assistant WebSocket service-call validation failures by ensuring target_soc is sent as an integer (HA rejects floats for target_soc in service data). The change is localized to the “immediate” charge/discharge service-call payload construction in the inverter control layer.
Changes:
- Cast
target_soctoint(...)inadjust_charge_immediate()service payload. - Cast
target_soctoint(...)inadjust_export_immediate()service payload.
Comment on lines
2758
to
2763
| current_rate = self.get_current_charge_rate() | ||
| service_data = { | ||
| "device_id": self.base.get_arg("device_id", index=self.id, default=""), | ||
| "target_soc": target_soc, | ||
| "target_soc": int(target_soc), | ||
| "power": int(current_rate), | ||
| } |
Comment on lines
2786
to
2791
| if target_soc < 100: | ||
| service_data = { | ||
| "device_id": self.base.get_arg("device_id", index=self.id, default=""), | ||
| "target_soc": target_soc, | ||
| "target_soc": int(target_soc), | ||
| "power": int(self.battery_rate_max_discharge * MINUTE_WATT), | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Predbat calls
charge_start_serviceordischarge_start_service,target_socwas passed as a float. Home Assistant's WebSocket API requires it to be an integer, causing:Changes
inverter.py—adjust_charge_immediate: casttarget_soctointin the service data dictinverter.py—adjust_export_immediate: same fix for the discharge pathpowerwas already wrapped inint();target_socnow follows the same pattern.