Skip to content

Fix target_soc passed as float in service API calls #4215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
springfall2008 merged 3 commits into from
Jul 9, 2026
Merged

Fix target_soc passed as float in service API calls #4215

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ad7ca87
Initial plan
Copilot Jul 8, 2026
8240491
Fix target_soc float to int conversion in service API calls
Copilot Jul 8, 2026
467e5eb
New test
springfall2008 Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/predbat/inverter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2758,7 +2758,7 @@ def adjust_charge_immediate(self, target_soc, freeze=False):
current_rate = self.get_current_charge_rate()
service_data = {
"device_id": self.base.get_arg("device_id", index=self.id, default=""),
"target_soc": target_soc,
"target_soc": int(target_soc),
"power": int(current_rate),
}
Comment on lines 2758 to 2763

Expand Down Expand Up @@ -2786,7 +2786,7 @@ def adjust_export_immediate(self, target_soc, freeze=False):
if target_soc < 100:
service_data = {
"device_id": self.base.get_arg("device_id", index=self.id, default=""),
"target_soc": target_soc,
"target_soc": int(target_soc),
"power": int(self.battery_rate_max_discharge * MINUTE_WATT),
}
Comment on lines 2786 to 2791

Expand Down
Loading