Skip to content

refactor(es/ast)!: use Function for object accessors - #12077

Open
magic-akari wants to merge 1 commit into
feat/ast-this-paramfrom
refactor/ast-object-get-set
Open

refactor(es/ast)!: use Function for object accessors#12077
magic-akari wants to merge 1 commit into
feat/ast-this-paramfrom
refactor/ast-object-get-set

Conversation

@magic-akari

Copy link
Copy Markdown
Member

Description:

BREAKING CHANGE:

Related issue (if exists):

@changeset-bot

changeset-bot Bot commented Jul 28, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 21951b3

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codspeed-hq

codspeed-hq Bot commented Jul 28, 2026

Copy link
Copy Markdown

Merging this PR will regress 1 benchmark

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 2 improved benchmarks
❌ 1 regressed benchmark
✅ 197 untouched benchmarks
⏩ 61 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation typescript/fast-strip/graphile-config 1.2 ms 1.3 ms -3.1%
Simulation es/lints/libs/three 50.6 ms 49.4 ms +2.46%
Simulation es/lints/libs/antd 158.7 ms 154.9 ms +2.44%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing refactor/ast-object-get-set (21951b3) with feat/ast-this-param (f3eddaa)

Open in CodSpeed

Footnotes

  1. 61 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@magic-akari
magic-akari force-pushed the refactor/ast-object-get-set branch 3 times, most recently from ca2361b to 0f9c1ae Compare July 28, 2026 10:49
@magic-akari
magic-akari force-pushed the refactor/ast-object-get-set branch from 0f9c1ae to 21951b3 Compare July 28, 2026 11:26
@magic-akari
magic-akari marked this pull request as ready for review July 28, 2026 12:06
@magic-akari
magic-akari requested review from a team as code owners July 28, 2026 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant