Skip to content

packages: Add VSCodium#1930

Closed
realpixelcode wants to merge 1 commit into
wimpysworld:mainfrom
realpixelcode:pixelcode-vscodium
Closed

packages: Add VSCodium#1930
realpixelcode wants to merge 1 commit into
wimpysworld:mainfrom
realpixelcode:pixelcode-vscodium

Conversation

@realpixelcode

@realpixelcode realpixelcode commented Jul 13, 2026

Copy link
Copy Markdown

Fix #1929.

Review in cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues found across 1 file

Confidence score: 2/5

  • In 01-main/packages/vscodium, the URL selection logic appears to always take the first .deb asset rather than matching the host architecture, which could install the wrong binary (or fail install) on amd64/arm64/ppc64el systems — update asset selection to filter by architecture before merging.
  • The new package in 01-main/packages/vscodium is not listed in 01-main/manifest, so it may be undiscoverable and skipped by manifest-driven tooling/CI expectations — add vscodium to the manifest in alphabetical order before merging.
Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="01-main/packages/vscodium">

<violation number="1" location="01-main/packages/vscodium:1">
P1: The newly added `vscodium` package definition is missing from the project manifest (`01-main/manifest`). Per `AGENTS.md`, every new package must be added to the manifest alphabetically so that it is discoverable and covered by CI installation tests. Without this registration, the package exists on disk but will not be listed or tested.</violation>

<violation number="2" location="01-main/packages/vscodium:5">
P1: The `URL` extraction always picks the first `.deb` release asset without considering the host CPU architecture. Because VSCodium publishes separate `.deb` packages per architecture, this can cause amd64, arm64, or ppc64el hosts to download a package built for a different architecture, and `apt`/`dpkg` will reject it with an architecture mismatch. The sibling package `codium` already handles this correctly by including `${HOST_ARCH}` in the `grep` pattern (`browser_download_url.*${HOST_ARCH}\.deb`). The same pattern should be used here to match the asset to the current host architecture.</violation>
</file>

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread 01-main/packages/vscodium
@@ -0,0 +1,10 @@
DEFVER=1

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1: The newly added vscodium package definition is missing from the project manifest (01-main/manifest). Per AGENTS.md, every new package must be added to the manifest alphabetically so that it is discoverable and covered by CI installation tests. Without this registration, the package exists on disk but will not be listed or tested.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At 01-main/packages/vscodium, line 1:

<comment>The newly added `vscodium` package definition is missing from the project manifest (`01-main/manifest`). Per `AGENTS.md`, every new package must be added to the manifest alphabetically so that it is discoverable and covered by CI installation tests. Without this registration, the package exists on disk but will not be listed or tested.</comment>

<file context>
@@ -0,0 +1,10 @@
+DEFVER=1
+ARCHS_SUPPORTED="amd64 arm64 ppc64el"
+get_github_releases "VSCodium/vscodium" "latest"
</file context>

Comment thread 01-main/packages/vscodium
ARCHS_SUPPORTED="amd64 arm64 ppc64el"
get_github_releases "VSCodium/vscodium" "latest"
if [ "${ACTION}" != prettylist ]; then
URL=$(grep -m 1 "browser_download_url.*\.deb\"" "${CACHE_FILE}" | cut -d '"' -f 4)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1: The URL extraction always picks the first .deb release asset without considering the host CPU architecture. Because VSCodium publishes separate .deb packages per architecture, this can cause amd64, arm64, or ppc64el hosts to download a package built for a different architecture, and apt/dpkg will reject it with an architecture mismatch. The sibling package codium already handles this correctly by including ${HOST_ARCH} in the grep pattern (browser_download_url.*${HOST_ARCH}\.deb). The same pattern should be used here to match the asset to the current host architecture.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At 01-main/packages/vscodium, line 5:

<comment>The `URL` extraction always picks the first `.deb` release asset without considering the host CPU architecture. Because VSCodium publishes separate `.deb` packages per architecture, this can cause amd64, arm64, or ppc64el hosts to download a package built for a different architecture, and `apt`/`dpkg` will reject it with an architecture mismatch. The sibling package `codium` already handles this correctly by including `${HOST_ARCH}` in the `grep` pattern (`browser_download_url.*${HOST_ARCH}\.deb`). The same pattern should be used here to match the asset to the current host architecture.</comment>

<file context>
@@ -0,0 +1,10 @@
+ARCHS_SUPPORTED="amd64 arm64 ppc64el"
+get_github_releases "VSCodium/vscodium" "latest"
+if [ "${ACTION}" != prettylist ]; then
+	URL=$(grep -m 1 "browser_download_url.*\.deb\"" "${CACHE_FILE}" | cut -d '"' -f 4)
+    VERSION_PUBLISHED=$(cut -d '/' -f 8 <<< "${URL//v/}")
+fi
</file context>
Suggested change
URL=$(grep -m 1 "browser_download_url.*\.deb\"" "${CACHE_FILE}" | cut -d '"' -f 4)
URL=$(grep -m 1 "browser_download_url.*${HOST_ARCH}\.deb\"" "${CACHE_FILE}" | cut -d '"' -f 4)

@realpixelcode

Copy link
Copy Markdown
Author

Unnecessary, because VSCodium has already been added as codium.

@realpixelcode realpixelcode deleted the pixelcode-vscodium branch July 13, 2026 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

App Request: VSCodium

1 participant