Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions 01-main/packages/vscodium
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
DEFVER=1

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1: The newly added vscodium package definition is missing from the project manifest (01-main/manifest). Per AGENTS.md, every new package must be added to the manifest alphabetically so that it is discoverable and covered by CI installation tests. Without this registration, the package exists on disk but will not be listed or tested.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At 01-main/packages/vscodium, line 1:

<comment>The newly added `vscodium` package definition is missing from the project manifest (`01-main/manifest`). Per `AGENTS.md`, every new package must be added to the manifest alphabetically so that it is discoverable and covered by CI installation tests. Without this registration, the package exists on disk but will not be listed or tested.</comment>

<file context>
@@ -0,0 +1,10 @@
+DEFVER=1
+ARCHS_SUPPORTED="amd64 arm64 ppc64el"
+get_github_releases "VSCodium/vscodium" "latest"
</file context>

ARCHS_SUPPORTED="amd64 arm64 ppc64el"
get_github_releases "VSCodium/vscodium" "latest"
if [ "${ACTION}" != prettylist ]; then
URL=$(grep -m 1 "browser_download_url.*\.deb\"" "${CACHE_FILE}" | cut -d '"' -f 4)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1: The URL extraction always picks the first .deb release asset without considering the host CPU architecture. Because VSCodium publishes separate .deb packages per architecture, this can cause amd64, arm64, or ppc64el hosts to download a package built for a different architecture, and apt/dpkg will reject it with an architecture mismatch. The sibling package codium already handles this correctly by including ${HOST_ARCH} in the grep pattern (browser_download_url.*${HOST_ARCH}\.deb). The same pattern should be used here to match the asset to the current host architecture.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At 01-main/packages/vscodium, line 5:

<comment>The `URL` extraction always picks the first `.deb` release asset without considering the host CPU architecture. Because VSCodium publishes separate `.deb` packages per architecture, this can cause amd64, arm64, or ppc64el hosts to download a package built for a different architecture, and `apt`/`dpkg` will reject it with an architecture mismatch. The sibling package `codium` already handles this correctly by including `${HOST_ARCH}` in the `grep` pattern (`browser_download_url.*${HOST_ARCH}\.deb`). The same pattern should be used here to match the asset to the current host architecture.</comment>

<file context>
@@ -0,0 +1,10 @@
+ARCHS_SUPPORTED="amd64 arm64 ppc64el"
+get_github_releases "VSCodium/vscodium" "latest"
+if [ "${ACTION}" != prettylist ]; then
+	URL=$(grep -m 1 "browser_download_url.*\.deb\"" "${CACHE_FILE}" | cut -d '"' -f 4)
+    VERSION_PUBLISHED=$(cut -d '/' -f 8 <<< "${URL//v/}")
+fi
</file context>
Suggested change
URL=$(grep -m 1 "browser_download_url.*\.deb\"" "${CACHE_FILE}" | cut -d '"' -f 4)
URL=$(grep -m 1 "browser_download_url.*${HOST_ARCH}\.deb\"" "${CACHE_FILE}" | cut -d '"' -f 4)

VERSION_PUBLISHED=$(cut -d '/' -f 8 <<< "${URL//v/}")
fi
PRETTY_NAME="VSCodium"
WEBSITE="https://vscodium.com"
SUMMARY="VSCodium is a community-driven, freely-licensed binary distribution of Microsoft’s editor VS Code."
Loading